Thread: [HELP]Bubblesort

Originally Posted by ShiroAzure's compiler

bubblesort.cpp:10: error: array must be initialized with a brace-enclosed initializer

In other words, this:

Code:

int array [arraySize] = (10,9,22,1,3,6,9,2,13,18,20);

should be:

Code:

int array [arraySize] = {10,9,22,1,3,6,9,2,13,18,20};

Look at your for loops carefully. Normally, there are three parts, but you only use two of them.

I'm really tempted to post what your for loops should look like, but really you can probably easily find 1 billion examples with Google.
So, I'm giving you a nudge to at least go and find some example for-loops and see if you can work out how yours is different. Searching the web is a really important thing to get used to as a software developer as you never stop needing to do it, not even after 20 years of programming.
Here is a useful link.

Thanks iMalc, that link has helped alot, i checked out some examples and for some reason my code still isnt quite working...

Code:

#include <iostream>
using namespace std;

int main()
{

int swapCount = 0;
int i, j;
const int arraySize = 11;
int array [arraySize] = {10,9,22,1,3,6,9,2,13,18,20};

for(i=0; i < arraySize-1; ++i){
        for(j=0; j < arraySize-1; ++j){
                        if(array[j-1] > array[j]){
                        int tempInt = array[j-1];
                        array[j-1] = array[j];
                        array[j] = tempInt;
                        }
                }

        cout << "After Sorting: " << endl;
        for(i=0; i < arraySize-1; ++i){
        cout << array[j] << " ";
        }
}
}

this code outputs : 20 20 20 20 20 20 20 20 20 20
The output is clearly wrong and it only outputs 10 numbers instead of 20, ahhhh headache >.< lol

Hmm, nobody else responded for two days. Wow sorry nobody replied earlier.
It looks like the first problem is that your indentation is not correct. The reason that people on here usually very heavily strees the importance of indentation is that it really does solve a lot of problems. With proper indentation, your code looks like this:

Code:

#include <iostream>
using namespace std;

int main()
{
    int swapCount = 0;
    int i, j;
    const int arraySize = 11;
    int array [arraySize] = {10,9,22,1,3,6,9,2,13,18,20};
    for (i=0; i < arraySize-1; ++i)
    {
        for (j=0; j < arraySize-1; ++j)
        {
            if (array[j-1] > array[j])
            {
                int tempInt = array[j-1];
                array[j-1] = array[j];
                array[j] = tempInt;
            }
        }
        cout << "After Sorting: " << endl;
        for (i=0; i < arraySize-1; ++i)
        {
            cout << array[j] << " ";
        }
    }
}

Now, take note of where your final loop lies. That's right, at a glance you can now see that it's inside your sorting loop - oops!
Format code perfectly - always!

The next issue is a buffer overrun. the 'j' loop starts at zero and yet the code inside it refers to array[j-1]. Your inner loop should start at 1. It should also go up to less than arraySize, not less than arraySize-1.